search

andre-r / centered-cursor-mode.el

An emacs minor mode for smooth scrolling
GNU General Public License v2.0
60 stars 12 forks source link

Centering does not take line-height into account #3

Closed hkjels closed 6 years ago

hkjels commented 6 years ago

I prefer having quite a gap between lines and this seems to move the center of drastically. Looking near the bottom of this screenshot, you can see where point ends up

skjermbilde 2018-01-12 kl 10 37 03

andre-r commented 6 years ago

Hello, I attempted a fix and it seems to work. Unfortunately I don't have much time right now to work on more fixes and features from the todo list.

hkjels commented 6 years ago

Hey, I just tested 0.5.7; unfortunately it doesn't seem like the fix did what it was suppose to. It might be my assumption of the bug that's incorrect though. I'll fork and see if I can grok your code. Would you accept a pull-request?

hkjels commented 6 years ago

After some debugging and resetting of ccm-vpos-init it works great! I really like the package btw 👍