Adding #include <linux/vmalloc.h> to file and result explanation.

andre-richter / pcie-lat

Generic x86_64 PCIe latency measurement module for the Linux kernel

GNU General Public License v2.0

56 stars 15 forks source link

Adding #include <linux/vmalloc.h> to file and result explanation. #1

Closed ghost closed 7 years ago

ghost commented 7 years ago

The code was not working for my server, running on Ubuntu 14.04 server. Please include the vmalloc file.

Another issue I faced was the number and graph explanation. It would be nice if you could add some explanation so that people can interpret the numbers/graph easily.

Thanks, Ankit

andre-richter commented 7 years ago

Hi,

thanks for the feedback. I think I last tested this on 12.04, hence the missing vmalloc. I added it now in 16bcc6da8fdaa0192d088c16bda9c938dc27f16d.

Regarding the graph, it is just the standard probability histogram that you can create with matplotlib (https://matplotlib.org/1.2.1/examples/pylab_examples/histogram_demo.html). In this case, it shows the distribution of read latencies to the respective PCIe device (for all values within 3-sigma).

BR, Andre

andre-richter commented 7 years ago

@ankitbhrdwj are you unblocked now?

Can we close this issue?

BR, Andre

ghost commented 7 years ago

@andre-richter Yes, please. Thanks.