search

andrea-michielan / SkyQRemote

Public repository of the Sky Q Remote app available for free on Google Play at https://play.google.com/store/apps/details?id=com.michielan.skyqremote
MIT License
5 stars 0 forks source link

Request: custom http calls for volume buttons #1

Open molexx opened 3 years ago

molexx commented 3 years ago

Volume buttons are understandably missing! Some users can increase/decrease the volume on their amp or TV by firing HTTP requests.

Please consider adding settings items to enter the URLs to call and, if filled, show the buttons.

vdallavalle commented 3 years ago

But what's the structure of those HTTP requests? Doesn't each producer have its own predefined REST api to be called? How can every producer be included in a single app?

molexx commented 3 years ago

It could be user-customisable. Initially just do GET: offer a URL field for the user to fill in, they can include query parameters if needed. Allow request headers to be specified.

Maybe later allow POST with a body.

vdallavalle commented 3 years ago

So transforming this simple app into something similar to Postman? Just for the volume buttons? Without even considering the messy UI required to send POST requests with custom fields, I think this is unreasonable first and foremost because most of the users (probably 95%) dont have any idea on what HTTP is. I agree with you that adding volume buttons could be a nice inprovement but I think this is not the way to get it done. A better solution must be found in order to implement this feature

molexx commented 3 years ago

Not quite postman :-) To start with many devices would be covered with a GET and inline query parameters. Later, the UI to set a POST body could be a simple textarea.

I don't see an easier way to deliver volume control. There are so many brands/models of tv and amp, IR blasters and home automation tools that it won't feasibly be possible to support many of them. This allows the user to do it if they have such a setup.