search

andreaalbergo / ingsw2022-AM48

MIT License
4 stars 0 forks source link

Code does NOT compile #9

Closed ingconti closed 2 years ago

ingconti commented 2 years ago

Cannot resolve method 'setProfessors' in 'SchoolGrid'

image

PLS fix asap

andreaalbergo commented 2 years ago

Sorry we had some problems with merging our commits, now it should run

From: ingconti @.> Date: Monday, 4 July 2022 at 22:35 To: andreaalbergo/ingsw2022-AM48 @.> Cc: Subscribed @.***> Subject: [andreaalbergo/ingsw2022-AM48] Code does NOT compile (Issue #9)

Cannot resolve method 'setProfessors' in 'SchoolGrid' [image]https://user-images.githubusercontent.com/4048423/177214096-026d641e-95d1-4ecf-bd48-11fe806e4744.png

PLS fix asap

— Reply to this email directly, view it on GitHubhttps://github.com/andreaalbergo/ingsw2022-AM48/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYC57WZ7IXNIWNXYHSQJGKDVSNDKLANCNFSM52UEWXVA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ingconti commented 2 years ago

other errors:

[ERROR] Tests run: 14, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.003 s <<< FAILURE! - in it.polimi.ingsw.model.SchoolBoardTest [ERROR] addStudentToDiningRoom1 Time elapsed: 0 s <<< ERROR! it.polimi.ingsw.exceptions.InvalidSelection: Your choice is invalid try again at it.polimi.ingsw.model.SchoolBoardTest.addStudentToDiningRoom1(SchoolBoardTest.java:38)

[ERROR] removeFromEntrance2 Time elapsed: 0.001 s <<< ERROR! it.polimi.ingsw.exceptions.InvalidSelection: Your choice is invalid try again at it.polimi.ingsw.model.SchoolBoardTest.removeFromEntrance2(SchoolBoardTest.java:205)

I do really ask myself how you run tests in past months....

andreaalbergo commented 2 years ago

We told our colleague to test the methods and he said they ran fine, there was probably some incongruence because we changed some of the methods and he forgot to update them, we are very sorry.

From: ingconti @.> Date: Monday, 4 July 2022 at 23:18 To: andreaalbergo/ingsw2022-AM48 @.> Cc: Andrea Albergo @.>, Comment @.> Subject: Re: [andreaalbergo/ingsw2022-AM48] Code does NOT compile (Issue #9)

other errors:

[ERROR] Tests run: 14, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.003 s <<< FAILURE! - in it.polimi.ingsw.model.SchoolBoardTest [ERROR] addStudentToDiningRoom1 Time elapsed: 0 s <<< ERROR! it.polimi.ingsw.exceptions.InvalidSelection: Your choice is invalid try again at it.polimi.ingsw.model.SchoolBoardTest.addStudentToDiningRoom1(SchoolBoardTest.java:38)

[ERROR] removeFromEntrance2 Time elapsed: 0.001 s <<< ERROR! it.polimi.ingsw.exceptions.InvalidSelection: Your choice is invalid try again at it.polimi.ingsw.model.SchoolBoardTest.removeFromEntrance2(SchoolBoardTest.java:205)

I do really ask myself how you run tests in past months....

— Reply to this email directly, view it on GitHubhttps://github.com/andreaalbergo/ingsw2022-AM48/issues/9#issuecomment-1174383640, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYC57W7L7B6CPTALT3SMNZTVSNIJZANCNFSM52UEWXVA. You are receiving this because you commented.Message ID: @.***>

ingconti commented 2 years ago

anyway wee use MAVEN so maven MUST allow to make package. Your not.

andreaalbergo commented 2 years ago

Should be ok now

From: ingconti @.> Date: Tuesday, 5 July 2022 at 00:17 To: andreaalbergo/ingsw2022-AM48 @.> Cc: Andrea Albergo @.>, Comment @.> Subject: Re: [andreaalbergo/ingsw2022-AM48] Code does NOT compile (Issue #9)

anyway wee use MAVEN so maven MUST allow to make package. Your not.

— Reply to this email directly, view it on GitHubhttps://github.com/andreaalbergo/ingsw2022-AM48/issues/9#issuecomment-1174427997, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYC57W34YUQBIXYNJENLT7TVSNPGPANCNFSM52UEWXVA. You are receiving this because you commented.Message ID: @.***>