andreadelprete / consim

GNU General Public License v3.0
14 stars 1 forks source link

stop-watch.hpp already included in expokit headers #4

Closed hammoudbilal closed 4 years ago

hammoudbilal commented 4 years ago

Hi @andreadelprete I managed to compile everything perfectly, however, the profiler you use (e.g. stopwatch) are already included in the expokit headers. This could result in multiple definition conflict while compiling. For now I just removed the line (#include "consim/utils/stop-watch.hpp") from simulator.cpp we might want to think of separating this in a better way

andreadelprete commented 4 years ago

Yes, you're right. I think the right solution should be to have them defined in two different namespaces, so there's no conflict.

hammoudbilal commented 4 years ago

for now I just removed the #include from consim itself, relies on the #include from expokit