search

andreafeccomandi / bibisco

Novel writing software
https://bibisco.com
GNU General Public License v3.0
693 stars 117 forks source link

[BUG] While bibisco is running, F5 doesn't work anymore (NOT limited to bibsco) #374

Open ZosoDerGoldene opened 6 days ago

ZosoDerGoldene commented 6 days ago

I'm using bibisco 4.0.0-SE on Windows 11 Pro Build 22631.4317, both on my desktop with a Logitech K860 and on my Surface Pro 8, either with the Surface keyboard or a separate K860. As soon as I start bibisco, the F5 stops working - system-wide, as far as I can tell. Explicitly tested with Firefox, Chrome, and Windows Explorer. As soon as I close bibisco, it starts working again.
While bibisco is running, the keypress/keyrelease events still seem to fire (e.g., on https://www.keyboardtester.com/tester.html), but it doesn't do anything (e.g., refresh). I'm pretty sure this started with 4.0.0-SE.

ZosoDerGoldene commented 6 days ago

Found the culprit, bibisco/app/index.js essentially disables F5 for everyone - hence the name globalShortcuts, I presume. I would be willing to submit a fix, but I'm unsure what the intention is; disable refreshing on F5 within bibisco?

ZosoDerGoldene commented 6 days ago

More information on the electron behaviour can be found here and here.

ZosoDerGoldene commented 5 days ago

May I propose using electron-localshortcut instead? I know this is only a minor issue, but it caused me to spend hours trying to find out what was wrong with my keyboards/drivers/browsers/OS setup, and I guess it will for other like-minded individuals, too.