search

andreaferretti / paths-js

Generate SVG paths for geometric shapes :bar_chart:
http://andreaferretti.github.io/paths-js-react-demo/
Apache License 2.0
1.71k stars 84 forks source link

Latest builds are broken #26

Closed dfunckt closed 9 years ago

dfunckt commented 9 years ago

dist/global/paths.js is broken for the last couple of releases (at least until 0.3.3 -- didn't check earlier). Latest commit fixes the issue but there's been no release incorporating it so far. It'd be wonderful if you released a new version with the fix.

andreaferretti commented 9 years ago

Uh? There is 0.3.4 exactly for this reason. Both packages.json and bower.json show version 0.3.4, and there is a git tag as well.

I am pretty sure that global should work, because it is the version I am using with Scala.js, via Webjars.

What is not working for you?

dfunckt commented 9 years ago

Yeah, but the issue exists in 0.3.4. This is dist/global/paths.js@0.3.4, and it doesn't work -- you will have to scroll to the very end of the file to see that it references undefined vars.

andreaferretti commented 9 years ago

Ok, I will check and in case publish 0.3.5

andreaferretti commented 9 years ago

You were right, I published 0.3.5

andreaferretti commented 9 years ago

I have also updated paths-scala-js to make use of 0.3.5, and at the same time took the opportunity to make some compatibility fixes for scala-js 0.6.5