search

andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.
GNU General Public License v2.0
3.63k stars 177 forks source link

Minor cleanup #212

Closed a1346054 closed 3 years ago

andreafrancia commented 3 years ago

Thank you for your contribution! The commit about the spelling is great and I have already included it. I don't think I need the others commits. I think that bash is always on /bin/bash on the supported platforms so I don't think I need to include this commit. I don't know yet what to do with the license. I prefer not to include commits that changes only the white spaces.

a1346054 commented 3 years ago

Thank you for the review comments.

A few comments to explain:

I included the bash commit because bash doesn't exist on /bin/bash on any of my systems. /bin/bash is a symlink to /usr/bin/bash here, and it is always nice to look up the correct bash to use in case the user has a newer bash installed in /usr/local/bin/bash or some other virtual environment.

If you wish, I can rework the whitespace fixing commit to only deal with missing final newlines (strictly speaking fixing a violation of posix definition of what a line is), making sure to use unix newlines, not windows newlines, and dropping the trailing whitespace fixes.

Regarding the licenses changes, it is nice to distribute the same license as what gnu.org is distributing. The license version stays the same. It is only changing the physical addresses of FSF in case someone wished to send some post there, updates some formatting deviations and correctly refers to LGPL as 'Lesser' and not 'Library'. No contributor needs to be contacted in order to make these changes to the license.