Fix unit tests not deleting temp directories - Githubissues

andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.

GNU General Public License v2.0

3.63k stars 177 forks source link

Fix unit tests not deleting temp directories #219

Closed zpuskas closed 2 years ago

zpuskas commented 2 years ago

Some tests were not deleting temporary directories polluting /tmp. This patch fixes all locations in the code where this was forgotten.

Additionally we apply a suffix on top of the randomly generated name for the temp directories (new name example: tmpwl2fvrn9_trash_cli_test) becasue:

it has no cost to us or the users
helps identify temporary directories as belonging to trash-cli tests
will make similar issues obvious in the future

Bug: GH-218