search

andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.
GNU General Public License v2.0
3.58k stars 179 forks source link

Simple maintenance improvements #246

Closed a1346054 closed 2 years ago

a1346054 commented 2 years ago

This is a continuation from #212 with better explanations in commit messages.

I've also dropped the commit that fixes whitespace issues.

andreafrancia commented 2 years ago

ok, keep -> | ed44fa9 Add missing final newline a1346054, 5 hours ago no, remove -> | cb15289 Use license file from gnu.org a1346054, 1 year ago no, remove -> | 2d9e984 Invoke bash through /usr/bin/env a1346054, 1 year ago no, remove -> | 797b80f No need to execute bash to start docker a1346054, 5 hours ago ok, keep -> | f869ed9 Remove executable bit from text files a1346054, 5 hours ago good, keep -> | 18c4cc5 Fix typos a1346054, 4 hours ago

Please pull the latest master and create a pull request on top of it with the commit I marked with "keep". About the license, open an issue with the reason of changing the file and the wget/curl command to use to download the license.

About the use of env instead of /bin/bash let's say that the scripts works very well with old bash versions. I'm using a Bash 3. I want to keep scripts compatible with older bash versions.

The same is about using sh instead of bash. I want to be sure bash with all their features. I don't want discover that a bashism works only on some computers but fails in another.

andreafrancia commented 2 years ago

In any case thank you for your contribution.

a1346054 commented 2 years ago

Understood, those commits are now removed.

andreafrancia commented 2 years ago

Great work. Thank you!