andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.
GNU General Public License v2.0
3.58k stars 179 forks source link

test fails after fix for #264 #272

Closed jmcantrell closed 1 year ago

jmcantrell commented 1 year ago

Describe the bug After a recent fix for issue #264, tests are failing, making the trash-cli-git aur package uninstallable.

trash-cli version Output of: trash-put --version 0.22.10.20 (git commit: 8cdb571504a8c5f0bafc4f1c9463ac7f0233ccba)

Are you using the latest version of trash-cli? Yes

Have you tried if the bug is present in the latest version of trash-cli? Yes

Operating system:

To Reproduce Copy and paste the commands (and their output) to execute in order to reproduce the behavior:

Followed the commands in the readme to set up the repo, then just ran pytest.

Output from pytest:

______________________________________________________________________________ TestPutScripts.test_trashes_connected_symlink _______________________________________________________________________________

self = <tests.test_put.test_trash_put_script.TestPutScripts testMethod=test_trashes_connected_symlink>

    def test_trashes_connected_symlink(self):
        self.make_connected_link(self.tmp_dir / 'link')

        result = run_command(self.tmp_dir, 'trash-put', [
            '-v',
            '--trash-dir', self.tmp_dir / 'trash-dir',
            'link',
        ])

>       self.assertEqual([
            "trash-put: 'link' trashed in %s" % (self.tmp_dir / 'trash-dir'),
        ], self.read_trashed_in_message(result), result.stderr)
E       AssertionError: Lists differ: ["tra[21 chars]d in /home/jeremy/.local/tmp/tmp4tzzmdat_trash[16 chars]dir"] != ["tra[21 chars]d in ~/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir"]
E       
E       First differing element 0:
E       "tras[20 chars]d in /home/jeremy/.local/tmp/tmp4tzzmdat_trash[15 chars]-dir"
E       "tras[20 chars]d in ~/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir"
E       
E         ["trash-put: 'link' trashed in "
E       -  '/home/jeremy/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir']
E       ?   ^^^^^^^^^^^^
E       
E       +  '~/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir']
E       ?   ^
E        : trash-put: volume of file: /home
E       trash-put: trying trash dir: /home/jeremy/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir from volume: /home
E       trash-put: 'link' trashed in ~/.local/tmp/tmp4tzzmdat_trash_cli_test/trash-dir

tests/test_put/test_trash_put_script.py:50: AssertionError
_______________________________________________________________________________ TestPutScripts.test_trashes_dangling_symlink _______________________________________________________________________________

self = <tests.test_put.test_trash_put_script.TestPutScripts testMethod=test_trashes_dangling_symlink>

    def test_trashes_dangling_symlink(self):
        self.make_dangling_link(self.tmp_dir / 'link')

        result = run_command(self.tmp_dir, 'trash-put', [
            '-v',
            '--trash-dir', self.tmp_dir / 'trash-dir',
            'link',
        ])

>       self.assertEqual([
            "trash-put: 'link' trashed in %s" % (self.tmp_dir / 'trash-dir'),
        ], self.read_trashed_in_message(result), result.stderr)
E       AssertionError: Lists differ: ["tra[21 chars]d in /home/jeremy/.local/tmp/tmpogx6h1oo_trash[16 chars]dir"] != ["tra[21 chars]d in ~/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir"]
E       
E       First differing element 0:
E       "tras[20 chars]d in /home/jeremy/.local/tmp/tmpogx6h1oo_trash[15 chars]-dir"
E       "tras[20 chars]d in ~/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir"
E       
E         ["trash-put: 'link' trashed in "
E       -  '/home/jeremy/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir']
E       ?   ^^^^^^^^^^^^
E       
E       +  '~/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir']
E       ?   ^
E        : trash-put: volume of file: /home
E       trash-put: trying trash dir: /home/jeremy/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir from volume: /home
E       trash-put: 'link' trashed in ~/.local/tmp/tmpogx6h1oo_trash_cli_test/trash-dir

tests/test_put/test_trash_put_script.py:35: AssertionError
andreafrancia commented 1 year ago

Please try the new commit and let me know. Thank you.

jmcantrell commented 1 year ago

Passes here 👍