search

andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.
GNU General Public License v2.0
3.53k stars 177 forks source link

Prevent calling `trash-list --trash-dirs` at eval time #336

Closed pinusc closed 3 months ago

pinusc commented 4 months ago

The previous behavior caused a significant completion slowdown on linux systems with unresponsive mountpoints, which need to time out before trash-list --trash-dirs returns. This is inevitable when completing arguments to --trash-dir, but it should not slowdown unrelated completion queries.

Fixes #335, and likely will make completion a little bit faster for everyone.

andreafrancia commented 3 months ago

Thank you, I've rebased and merge manually. Your commit is here: https://github.com/andreafrancia/trash-cli/commit/1cb2be168d1a3a04861eca0652e4e51e7b9d029e