search

andrealufino / Deviice

Swift library to easily check the current device and some more info about it.
MIT License
73 stars 12 forks source link

Complete Name should be descriptive even when new iPhones get released #3

Closed Sn0wfreezeDev closed 6 years ago

Sn0wfreezeDev commented 6 years ago

It took a while, but we recently noticed that the new iPhone X (and 8, 8+) would be named as "Unknown-Unknown-Unknown" when we use an old version of the library. In some cases this may be okay, when you check the type or model before submitting that name to the server. I think it would be a nice addition if the identifier is added to the complete name if the device is unknown in the current state of the library. This would prevent in some cases that the app needs to be updated just because new phones came out which are not on the list.

I hope you agree to my addition

andrealufino commented 6 years ago

I've also updated the Cocoapod.

Thanks for your addition!