Dropped `widget` element, introduced specialized element/widget types.

andreamancuso commented 3 months ago

Summary by CodeRabbit

New Features
- Introduced new widget type identifiers in kebab-case format for consistency across the application.
Bug Fixes
- Addressed issues with widget type identification by modifying internal state management and initialization values.
Chores
- Cleaned up exports by removing obsolete widget types and improving the type definitions for clarity and maintenance.

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes across the dear-imgui package involve a significant normalization of widget type identifiers, shifting from PascalCase to a consistent kebab-case format. This semantic update enhances readability and aligns with modern naming conventions, improving the overall structure of the widget system. Additionally, some internal logic and rendering adjustments in various components have been implemented to reflect this new identification style while preserving the functionality of existing elements.

Changes

Files	Change Summary
`.../button.h`, `.../checkbox.h`, `.../clipped_multi_line_text_renderer.h`, `.../combo.h`, `.../image.h`, `.../input_text.h`, `.../map_view.h`, `.../multi_slider.h`, `.../separator_text.h`, `.../slider.h`, `.../table.h`, `.../text.h`	Updated `m_type` initialization from PascalCase to kebab-case (e.g., from `"Button"` to `"di-button"`).
`.../reactimgui.cpp`	Standardized string keys in `m_element_init_fn` from camel case to kebab case across all widget types.
`.../child.cpp`, `.../collapsing_header.cpp`, `.../group.cpp`, `.../item_tooltip.cpp`, `.../tabs.cpp`, `.../text_wrap.cpp`, `.../tree_node.cpp`, `.../window.cpp`, `.../widget.cpp`	Changed `m_type` member initialization from PascalCase to kebab-case (e.g., `"Child"` to `"child"`).
`.../global.d.ts`, `.../BulletText.tsx`, `.../Button.tsx`, `.../Checkbox.tsx`, `.../Child.tsx`, `.../ClippedMultiLineTextRenderer.tsx`, `.../CollapsingHeader.tsx`, `.../Combo.tsx`, `.../DIWindow.tsx`, `.../DisabledText.tsx`, `.../Group.tsx`, `.../Image.tsx`, `.../InputText.tsx`, `.../ItemTooltip.tsx`, `.../MapView.tsx`, `.../MultiSlider.tsx`, `.../PlotView.tsx`, `.../Separator.tsx`, `.../SeparatorText.tsx`, `.../Slider.tsx`, `.../TabBar.tsx`, `.../TabItem.tsx`, `.../Table.tsx`, `.../TextWrap.tsx`, `.../TreeNode.tsx`, `.../UnformattedText.tsx`	Updated JSX elements from `<widget>` to specific components (e.g., `<button>`, `<checkbox>`, etc.).
`.../components.tsx`	Removed `Unknown` from the exported components.
`.../types.ts`	Modified `WidgetPropsMap` type definition by adding and removing various widget types and their properties.
`.../ReactNativePrivateInterface.js`, `.../nativeFabricUiManager.ts`	Updated internal logic related to widget types and handling within the React Native interface.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Component

    User->>App: Interacts with UI
    App->>Component: Render component
    Component->>Component: Initialize m_type
    Component->>App: Return rendered UI
    App->>User: Display updated UI

🐰 "In the land where widgets play,
We’ve changed their names in a merry way,
From Caps to kebabs, oh what a sight,
Our code now dances, gleaming bright!
Hoppity hop, let’s celebrate,
New names, new style—it feels so great!"
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

andreamancuso commented 3 months ago

@coderabbitai please review

coderabbitai[bot] commented 3 months ago

@andreamancuso: I will review the changes in the pull request.

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.