Closed andreamancuso closed 1 week ago
[!WARNING]
Rate limit exceeded
@andreamancuso has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 7 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between ec79a0ed26afccffd3065d7752ec5ef4061c9c82 and d74c2687295ccb9a7f27d380e9d0aa0719553cbe.
This pull request introduces a comprehensive refactor of the dear-imgui
package, transitioning from the ReactImgui
framework to the XFrames
framework. Key changes include renaming components, updating method signatures, and modifying import paths across various files. The .gitignore
file is updated to exclude new xframes
related files, and CMake configurations reflect the new project name. The updates affect numerous components, ensuring that the functionality remains intact while aligning with the new library structure.
File Path | Change Summary |
---|---|
packages/dear-imgui/cpp/app/.gitignore | Added prebuilds to ignore list. |
packages/dear-imgui/cpp/app/CMakeLists.txt | Renamed project from reactDearImgui to xframes . Updated source files. |
packages/dear-imgui/cpp/app/include/element/element.h | Changed pointer types from ReactImgui* to XFrames* in Element class. |
packages/dear-imgui/cpp/app/include/element/layout_node.h | Changed class declaration from ReactImgui to XFrames . |
packages/dear-imgui/cpp/app/include/imgui_renderer.h | Changed pointer types from ReactImgui* to XFrames* in ImGuiRenderer . |
packages/dear-imgui/cpp/app/include/implot_renderer.h | Changed constructor parameter from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/button.h | Changed pointer types from ReactImgui* to XFrames* in Button class. |
packages/dear-imgui/cpp/app/include/widget/checkbox.h | Changed pointer types from ReactImgui* to XFrames* in Checkbox class. |
packages/dear-imgui/cpp/app/include/widget/child.h | Changed pointer types from ReactImgui* to XFrames* in Child class. |
packages/dear-imgui/cpp/app/include/widget/clipped_multi_line_text_renderer.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/collapsing_header.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/combo.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/group.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/image.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/input_text.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/item_tooltip.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/map_view.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/multi_slider.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/plot_candlestick.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/plot_line.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/separator.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/separator_text.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/slider.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/styled_widget.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/table.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/tabs.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/text.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/text_wrap.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/tree_node.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/widget.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/widget/window.h | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/include/xframes.h | Renamed ReactImgui to XFrames throughout the file. |
packages/dear-imgui/cpp/app/src/element/element.cpp | Changed pointer types from ReactImgui* to XFrames* in Element class. |
packages/dear-imgui/cpp/app/src/imgui_renderer.cpp | Changed pointer types from ReactImgui* to XFrames* in ImGuiRenderer . |
packages/dear-imgui/cpp/app/src/implot_renderer.cpp | Changed pointer types from ReactImgui* to XFrames* in ImPlotRenderer . |
packages/dear-imgui/cpp/app/src/widget/button.cpp | Changed pointer types from ReactImgui* to XFrames* in Button class. |
packages/dear-imgui/cpp/app/src/widget/checkbox.cpp | Changed pointer types from ReactImgui* to XFrames* in Checkbox class. |
packages/dear-imgui/cpp/app/src/widget/child.cpp | Changed pointer types from ReactImgui* to XFrames* in Child class. |
packages/dear-imgui/cpp/app/src/widget/clipped_multi_line_text_renderer.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/collapsing_header.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/combo.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/group.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/image.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/input_text.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/item_tooltip.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/map_view.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/multi_slider.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/plot_candlestick.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/plot_line.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/separator.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/separator_text.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/slider.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/styled_widget.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/table.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/tabs.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/text.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/text_wrap.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/tree_node.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/widget.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/app/src/widget/window.cpp | Changed pointer types from ReactImgui* to XFrames* . |
packages/dear-imgui/cpp/tests/CMakeLists.txt | Added OpenGL as a required package and updated source files. |
packages/dear-imgui/cpp/tests/vcpkg.json | Renamed package from reactdearimguitests to xframestests . |
packages/dear-imgui/examples/cra-example/package.json | Updated package name and dependencies to reflect new structure. |
packages/dear-imgui/examples/cra-example/src/App.tsx | Updated imports and JSX to use XFrames instead of ReactImgui . |
packages/dear-imgui/examples/electron-example/package.json | Updated package name and dependencies to reflect new structure. |
packages/dear-imgui/examples/electron-example/src/components/Main.tsx | Updated imports and JSX to use XFrames instead of ReactImgui . |
packages/dear-imgui/examples/electron-example/webpack.rules.ts | Added rule for handling .data files with file-loader . |
packages/dear-imgui/examples/grafana-panel-example/package.json | Updated package name and dependencies to reflect new structure. |
packages/dear-imgui/examples/grafana-panel-example/src/components/SimplePanel.tsx | Updated imports and JSX to use XFrames instead of ReactImgui . |
packages/dear-imgui/ts/src/lib/stylesheet/xframes-style.ts | Updated styling types to reflect new XFrames structure. |
packages/dear-imgui/ts/src/lib/widgetRegistrationService.ts | Updated to use XFramesStyle instead of ImGuiStyle . |
packages/dear-imgui/ts/xframes-node/XFrames.tsx | Updated imports and exports to reflect new XFrames library. |
In the garden where code does bloom,
A rabbit hops, dispelling gloom.
"XFrames" now leads the way,
As "ReactImgui" fades away.
With each new line, the widgets dance,
In a world of code, we take our chance! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Failed conditions
11 Security Hotspots
23.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
Summary by CodeRabbit
Release Notes
New Features
ReactImgui
toXFrames
across the application, enhancing the framework for rendering and UI components.XFrames
, includinguseXFramesWasm
anduseXFramesFonts
.XFramesStyleForPatching
.Bug Fixes
Documentation
Chores
.gitignore
to reflect new file structures and dependencies.