search

andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView
MIT License
6.05k stars 633 forks source link

The TabBar does not appear when resuming from a video inside a WKWebView #321

Closed lpbas closed 6 years ago

lpbas commented 6 years ago

Describe the bug Hello. First of all I want to thank you for this library, it has helped me very much! The bug I'm facing is that I have a WKWebView that makes my NavBar and TabBar hide when scrolled. When the navigaiton elements are hidden and a youtube video begins playing inside the webView, when I dismiss the video from fullscreen, the TabBar does not appear again, but stays hidden untill I kill the app and restart it. The navigation bar appears, but its title is Hidden, untill I scroll again, and the title appears as normal.

To Reproduce Steps to reproduce the behavior:

  1. Create a WKWebView
  2. Make the NavBar and the TabBar follow the webView
  3. Play any video that will show the fullscreen ios video player.
  4. Exit the fullscreen video
  5. The NavBar has appeared (but its title is hidden), but the TabBar is still hidden and does not re-appear when scrolling.

Expected behavior The TabBar should also re-appear when entering a fullscreen video in a webView, along with the NavBar

Thank you for your time!

andreamazz commented 6 years ago

Hey @L4grange I'm a little swamped at the moment, so I've tried a quick blind fix in c708417. Can you test it out?

lpbas commented 6 years ago

Yes, the new commit fixes the issue with videos (as well as other fullscreen actions*), thank you so much! :)

(I am using the ImageSlideshow library, which presents a fullscreen image when tapped, which was also making the TabBar stay hidden, and now its fixed!)

andreamazz commented 6 years ago

Great to hear. I'll push a new release with the fix.