search

andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView
MIT License
6.05k stars 633 forks source link

Fix issues #322, #336 #337

Closed StefaniOSApps closed 6 years ago

StefaniOSApps commented 6 years ago

should fix #336

StefaniOSApps commented 6 years ago

should fix #322 large titles

StefaniOSApps commented 6 years ago

now it works with transcluded style ...

https://imgur.com/a/PBbzydg

StefaniOSApps commented 6 years ago

ups

andreamazz commented 6 years ago

Hi @StefaniOSApps thanks for the contribution. This PR is a little messy though, I rather avoid the deletion and reupload of the whole file. Also I'd like some context behind the decision to remove the updateContentInset call, which was there for a reason (it keeps the scrollbar from twitching). I agree it was problematic, but if we decide to remove it I rather do so in a separate PR.

BTW, I'll take a look at the other issues as soon as possible, right now I'm a little overwhelmed at work

andreamazz commented 6 years ago

I'll close this for now, if you can create a fresh PR with just that change (also, as suggested by Hound, keep a space after the comma), that'd be great.

StefaniOSApps commented 6 years ago

It's OK @andreamazz. However, I find the solution with the StatusbarHeight> = 0 good. It fixes #336. See https://imgur.com/a/PBbzydg. Should I re-submit this as a single PullRequest?