search

andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView
MIT License
6.05k stars 633 forks source link

Scrolling Issue >> upgrade to Scrolling Delegate required #358

Open StefaniOSApps opened 5 years ago

StefaniOSApps commented 5 years ago

Describe the bug If you scroll and slide your finger diagonally across the screen, the NavigationBar will not recognize it. So it will not collapse and will not expand. Furthermore, with scrolling small steps, the NavigationBar will not collapse and expand. Even if you include a UiTableview in a UiTableview and only scroll inside, the UiNavigationBar becomes unnecessarily collapsed or expand. This does not happen with a delegate method. The error is the same in all three causes.

To Reproduce Steps to reproduce the behavior:

  1. Open Demo or your own project
  2. Slide your finger diagonally across the screen to scroll the UiTableView or UiCollectionView or...
  3. NavBar does not collapse or expand.

Expected behavior NavBar should collapse or expand

Screenshots If you need a video, so I can deliver it.

andreamazz commented 5 years ago

It's the intended behavior: https://github.com/andreamazz/AMScrollingNavbar/blob/master/Source/ScrollingNavigationController.swift#L663-L669 I can add an option for this if needed.

StefaniOSApps commented 5 years ago

That sounds good. There are 3 cases.

  1. Diagonal scrolling
  2. Scroll if a UiTableView has been integrated into a UiTableViewCell
  3. Scrolling is not recognized when the scrolling steps are very small.

one more issue

  1. Drag and Drop UiTableViewCells (The NavBar did collapse or expand by dragging (not scrolling))

https://github.com/andreamazz/AMScrollingNavbar/issues/358#issuecomment-444897315 This solves the first point. There are still 2 left.