Remove the deprecated API usage problem

andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView

MIT License

6.05k stars 634 forks source link

Remove the deprecated API usage problem #372

Closed gslondon closed 4 years ago

gslondon commented 4 years ago

Apple have started to clamp down on the use of deprecated APIs. In AMScrollingNavBar/ScrollingNavbar+Sizes.swift there is reference to this deprecated control.

This fork and pull request fixes the issue.

(ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs)

andreamazz commented 4 years ago

Thanks. I was debating on this after #371 whether to leave the UIWebView reference under a compiler level #if of we should just kill it. At any rate, it's probably best to adopt 5.4.0 as version number, since this can be breaking

gslondon commented 4 years ago

Hi andreamazz,

Thanks for the reply.

Just to keep you up to date with proceedings, CI has passed and our continuous deployment at some point will place a binary with iTunes Connect. When this is verified and no warnings are received I will move this pr from draft and update the version number as you suggested.