andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView
MIT License
6.05k stars 634 forks source link

Change shouldScrollWithDelta to take in account the followersHeight #382

Closed alexookah closed 4 years ago

alexookah commented 4 years ago

I added followersHeight in ScrollingNavbar+Sizes to use it anywhere needed. Fixed the issue that it would not scroll. The case was when the UINavigationBar.appearance().isTranslucent = false was not working correctly when the navbar was collapsed.

this fixes issue https://github.com/andreamazz/AMScrollingNavbar/issues/379

alexookah commented 4 years ago

@andreamazz what do you think?

andreamazz commented 4 years ago

Hi @Alexookah looks good, nice catch. Thank you!