search

andreamazz / AMScrollingNavbar

Scrollable UINavigationBar that follows the scrolling of a UIScrollView
MIT License
6.05k stars 634 forks source link

issue 379 fix #383

Closed alexookah closed 4 years ago

alexookah commented 4 years ago

The previous fix was wrong. This is the correct value for the case when there is no searchController in the navigationBar.

This fix doesnt handle the case for .isTranslucent = false with searchController in the navigationBar. I couldnt handle it because the checkSearchController(delta) was not really working correct to take that in account as well.

I also think updateContentInset are also wrong when the searchController exists for .isTranslucent = false

alexookah commented 4 years ago

@andreamazz sorry for my previous PL mistake.

alexookah commented 4 years ago

@andreamazz what do you think?

andreamazz commented 4 years ago

Great, thanks!