search

andreamazz / AMWaveTransition

Custom transition between viewcontrollers holding tableviews
MIT License
2.37k stars 292 forks source link

Gestures cause cells to be misaligned #11

Open Sumukh opened 10 years ago

Sumukh commented 10 years ago

Gestures

Is keeping track of the touch position necessary? The gesture recognizer could just trigger the normal transition?

andreamazz commented 10 years ago

Hi @Sumukh Can you elaborate? How can I reproduce the issue?

Sumukh commented 10 years ago

This behavior was triggered with a swipe from the left of the screen after selecting a row. Using that gesture causes the cells to be misaligned. I'll take another look at it soon.

andreamazz commented 10 years ago

Which iOS version are you running?
Also, make sure that you are running the latest commit in the repo, IIRC that bug was fixed.
I'll push a new version on cocoapods.

andreamazz commented 10 years ago

Ok, version 0.5.2 is up, looks like I forgot to push some changes, sorry.

Sumukh commented 10 years ago

I just pulled and it has the same issue (on a left swipe). I should have mentioned that I'm on iOS 8.

cuva commented 10 years ago

First and foremost: very nice library - good job.

I have the same problem here on iOS 8 Beta 5 (Xcode beta 6). Everything works fine as long as the interactiveTransition is not being used. It happens on the Demo app launched in the sim.

Is this an issue you're planning on looking into sometime soon?

Cheers,

andreamazz commented 10 years ago

Hi.
Yes, right now in iOS8 the gesture is rather glitchy, I'll work on it in the next few days, it should be rather trivial. I'll keep you posted.

cuva commented 10 years ago

Fantastic. Thanks for the update.

Sashke commented 10 years ago

To fix this behavior just place adding subview before kick cells of toVC, and replace [self.navigationController.view addSubview:toVC.view] with [self.navigationController.view insertSubview:toVC.view belowSubview:self.navigationController.navigationBar]; You can check my fork, branch "Sashke".

andreamazz commented 10 years ago

Brilliant, thanks @Sashke, your fix works like a charm.
@Sumukh checkout the latest commit and let me know if the issue is gone.

cuva commented 10 years ago

Hey @andreamazz

Thanks for fixing this, It indeed appears to fix the interactive issue on iOS8. However the fix above introduces a problem if using a navigation controller without a navigation bar.

It works just fine when using the back button, but the interactive back gesture doesn't behaves as expected. Please see the following minimal sample project for iOS 8 (I've applied manually the latest commit in the Pods dep): https://github.com/cuva/TestAMWaveTransition

I've tried to discover where it comes from but modifying the Y values didn't seem to make much change.

Cheers.