andreamazz / AMWaveTransition

Custom transition between viewcontrollers holding tableviews
MIT License
2.37k stars 292 forks source link

Tabbar is moved out of the screen alongside the cells #21

Open AllLuckly opened 8 years ago

AllLuckly commented 8 years ago

hello,If there is tabbar, tabbar, how can we not follow the move?

andreamazz commented 8 years ago

Can you elaborate a bit more?

AllLuckly commented 8 years ago

I use is on the home page, the home page, there is a uitabbar. When I click on the home page of the cell into the details and then return. Uitabbar also will follow the animation. I want to return when UITabBar does not need the animation.

andreamazz commented 8 years ago

Uhm, the tab bar animates? That's odd, can you include a video capture of the app by any chance?

AllLuckly commented 8 years ago

Click this link to see the effect, I do not want the bottom part of the blue don https://github.com/AllLuckly/AllLuckly.github.io/blob/master/12.gif?raw=true

andreamazz commented 8 years ago

Oh, I'm an idiot, I was thinking about another library :grimacing:

Ok, can you show me your visibleCells method? You are pushing the new controller in the navigation controller's stack, right?

AllLuckly commented 8 years ago

yes,then back,Sorry, my English is poor.

andreamazz commented 8 years ago

No problem. Can you post your visibleCells method implementation?

AllLuckly commented 8 years ago
- (id<UIViewControllerAnimatedTransitioning>)navigationController:(UINavigationController *)navigationController
                                  animationControllerForOperation:(UINavigationControllerOperation)operation
                                               fromViewController:(UIViewController*)fromVC
                                                 toViewController:(UIViewController*)toVC
{
    if (operation != UINavigationControllerOperationNone) {

        return [AMWaveTransition transitionWithOperation:operation];
    }
    return nil;
}

- (NSArray*)visibleCells {
    return [self.tabView visibleCells];
}

- (void)dealloc
{
    [self.navigationController setDelegate:nil];
}

Looking at your demo writing.

andreamazz commented 8 years ago

Looks good. Mmmm, it might be a bug, the tabbar should remain in place. I'll take a look at it.

AllLuckly commented 8 years ago

oh,thanks,The effect is very good

valentyn-dymaretskyi commented 7 years ago

Hey, have any news on this bug?