search

andreamazz / BubbleTransition

A custom modal transition that presents and dismiss a controller with an expanding bubble effect.
MIT License
3.32k stars 250 forks source link

no need to call appearance methods in fullscreen style. #39

Closed ty0x2333 closed 6 years ago

ty0x2333 commented 7 years ago

I'm getting the following warning when I try to present a UINavigationController.

Unbalanced calls to begin/end appearance transitions for <UINavigationController>.

UIModalPresentationFullScreen already handle appearance method calls. no need to call beginAppearanceTransition and endAppearanceTransition

Reference

https://github.com/zoonooz/ZFDragableModalTransition/issues/49 https://github.com/zoonooz/ZFDragableModalTransition/commit/ced1811818d029d006f3fcdb9ce1199cbc39c9e9

dilizarov commented 6 years ago

I'm having the same. Doesn't seem like this is getting merged in? @luckytianyiyan

andreamazz commented 6 years ago

Sorry, this flew over my head, merging now.

Thank you @luckytianyiyan

andreamazz commented 6 years ago

Merged manually, it was conflict hell.