search

andreamazz / SlideOutNavigation

SlideOut Navigation Controller for iOS.
MIT License
210 stars 49 forks source link

Unexpected effects for swiped view #13

Closed moleksyuk closed 11 years ago

moleksyuk commented 11 years ago

Hi @andreamazz again :smile:

I've caught very interesting issue.

I've created a simple project based on one of your examples. You can download it here

Description of example 1.Settings can be shown only by clicking on button:

[self.slideoutController setSlideoutOptions:@{AMOptionsEnableGesture : @(NO)}];

2.There is 'First View' that has UITableView and 'Child' bar button to push similar view. As swipe gesture is disabled you can't open settings from 'Child View'.

If you look at my video on youtube you can see that during some panic clicking it's possible to have loaded 'Child View' in slided out view. Maybe it sounds not clear but hope video will explains better.

After that this slided out view can catch events and you can return to parent view and make some actions on it.

As I see AMSlideOutNavigationController during showing side menu just move content for some value and put transparent view on it. (Correct me if I'm wrong)

  1. First of all what can you say about this video?
  2. What about not moving view but making screenshot and moving screenshot to avoid such side effects when slided out view can catch events?
andreamazz commented 11 years ago

Hi @moleksyuk Check commit 2f66c1eeb8 where the user interaction on the current view is disabled when the tray is open. Let me know.

Btw, the first implementation of this controller used a screenshot to display the content view, as you suggest, but I wanted to have a 'live' view even when the slide menu is open (the same behaviour of apps like facebook or youtube).

moleksyuk commented 11 years ago

@andreamazz I'm agree with you that 'live' view looks much better but as you see it has some side effects :disappointed:

I'll update the ticket after testing soon.

moleksyuk commented 11 years ago

@andreamazz bad news - still reproducible in v1.2.3 :disappointed:

andreamazz commented 11 years ago

I didn't push a new version, I just made a small fix in the sample code: https://github.com/andreamazz/SlideOutNavigation/commit/2f66c1eeb8fe767d571da7ce6bfa92af31bf6c07

Check against this code.

moleksyuk commented 11 years ago

Ah sorry, didn't get you. I've just tried with commit 2f66c1e and unfortunately still reproducible.

andreamazz commented 11 years ago

Commit 1ad6f58cb9d765ea9148fbc59ca23483ae9c9766 should fix this issue.

moleksyuk commented 11 years ago

I've just tested with commit 1ad6f58 and still able to have such case: 2013-05-02 19 38 17

But as I see swiped view doesn't interact with user's touches, so clicking on 'Back to parent' button will open view. BTW as I see it takes me more time to reproduce case in screenshot.

So, for this moment it satisfies my expectation and I'm closing ticket.

@andreamazz again and again a lot of thanks for your support, amazing fixes and great job. :beer: :beer: :beer: :beer: