search

andreamazz / SlideOutNavigation

SlideOut Navigation Controller for iOS.
MIT License
210 stars 49 forks source link

Fixed issues with table view being too high in landscape #83

Closed drallgood closed 10 years ago

drallgood commented 10 years ago

I don't know why this code was in place but it was certainly wrong. When the device is rotated, the width and height of the screen change accordingly. Thus it makes absolutely no sense to flip those two when the screen is in landscape mode.

This resulted in the table view being too high (exactly as high as the screen is wide) and the lowest few elements not being accessible anymore.

fixes #78

andreamazz commented 10 years ago

Hi @drallgood IIRC the code was there since previous versions of iOS would always return the same width and height for both orientation, so a check was needed. Have you tested the new code on iOS7 and iOS6 (I'm REALLY reluctant to support iOS6, but there are some devs still targeting that)?

drallgood commented 10 years ago

Hi @andreamazz I completely forgot about iOS7 ;) This is what happens when you're so focused on iOS8 changes. Thanks for catching that!

This issue should be fixed now. It basically checks for iOS8 and higher now and just uses the width/height in those cases (I tested it with 7.0 and 8.0). .

andreamazz commented 10 years ago

Awesome!
Thank you for your contribution!