andreamazz / SlideOutNavigation

SlideOut Navigation Controller for iOS.
MIT License
210 stars 49 forks source link

Side button catches click on large piece of area #9

Closed moleksyuk closed 11 years ago

moleksyuk commented 11 years ago

Steps to reproduce:

  1. Run SlideoutStroryboardSample
  2. Try to click on rectange area marked as red (see screenshot)

Actual: clicking far from Side button on UINavigationBar fires action, even though clicking on View area which doesn't know about button will fire click action too. Expected: ~ only yellow area should accept clicks

SideButtonBug

andreamazz commented 11 years ago

That's weird. Wrapping the button in a UIView fixed the quirk though. Thanks for your feedback, the fix is in commit 257c1b2394

iesta commented 11 years ago

Is there a way to redefine the area once the class has loaded ?

andreamazz commented 11 years ago

Currently no, I can expose the bar button item if needed though. Let me know

iesta commented 11 years ago

Yes that would be great :+1:

In the same vein, is it possible to add views over and under the tableview (menu) ?

andreamazz commented 11 years ago

I've added this method:

- (void)setLeftBarButton:(UIBarButtonItem*)barButton;

You can set the target or the selector for your new button to nil, so they'll be overridden to the proper ones.

As for the other question: I plan to add the feature in the future, currently it's not possible.