search

andreamazz / SubtleVolume

Replace the system volume popup with a more subtle indicator.
MIT License
1.2k stars 63 forks source link

codebeat badge #3

Closed korzonek closed 8 years ago

korzonek commented 8 years ago

Is it fine to add codebeat badge to README?

codebeat is automated code review tool for Swift,Ruby,Go & Python that helps get instant feedback on code quality.

"Quick wins" suggested by codebeat could be a nice candidate for a pull request and help other developers become contributors.

FYI. To be fully open and honest. I'm co-founder of codebeat.

andreamazz commented 8 years ago

Sure, why not. There's just a thing that you might want to consider:

Too many function arguments SubtleVolume.observeValueForKeyPath(4 arguments)

That function is a system defined callback :smiley: so there's no way to reduce the number of arguments.

Anyway, good luck and thanks for the PR.

korzonek commented 8 years ago

@andreamazz thank you :bow: