andreapollastri / cipi

Install and manage your server like a pro! With Cipi you don’t need to be a Sys Admin to deploy and manage websites and PHP applications powered by cloud VPS.
https://cipi.andreapollastri.net
1.09k stars 223 forks source link

Alias Domain SSL Config goes into default conf #359

Closed WorksDev closed 2 years ago

WorksDev commented 2 years ago

If I assign an alias to a domain and request an SSL certificate for all domains, the SSL configuration is written to the default config - where it potentially does not belong. Also, technically speaking, no further configuration should be created for the alias, but only the server_name of the original domain should be extended.

andreapollastri commented 2 years ago

Sorry but I can not follow you! Any alias has its nginx config with its SSL cert... there are no issue in aliases and SSLs. Best. Andrea

WorksDev commented 2 years ago

Sorry but I can not follow you! Any alias has its nginx config with its SSL cert... there are no issue in aliases and SSLs. Best. Andrea

Ok to make it clear:

Expected in my Opinion:

What happens on my side:

andreapollastri commented 2 years ago

Ok thank you for the detail! I'll check this flow and I'll update this issue in next days!