Closed askeron closed 3 years ago
andreas-mausch
commented
4 years ago Wow thanks. Have you tested it and verified its functional?
I really need to set up my dev environment again..
One thing I've noticed on the first look: it seems to replace the old buttons, right? I'd prefer if it would add new buttons instead
askeron
commented
4 years ago Sadly, no. I'm a developer, but I do mostly Java, Kotlin and NodeJS. The last time I wrote C and C++ was in collage. I tried to compile your code with Visual Studio 2019, but failed because there seems to be several thing that still link to Visual Studio 2017 and 2010. (At least the error messages indicated this.) And I got this error with your code independently from the new code, so that I assume it is only because of my building environment. But I looked through the diffs and I am understanding most of the changes. They seem legit and as I understand the diff, he did not remove the single export buttons but added additional buttons for bulk export. He only refactored the buttons so that both buttons could use the same subfuction.
andreas-mausch
commented
3 years ago Hi @askeron,
I've merged the changes on command-line and resolved the conflicts with the newest master. However, github now doesn't recognize the changes are already in master, and your name doesn't appear in the git log. I'm sorry about that. :( (If you know how to fix it, please let me know)
Everything worked without any changes, so thank you very much for the contribution.
askeron
commented
3 years ago That's fine for me. The important things is that it made it in the master.
This adds buttons to bulk export all chats at once. (see issue #36 ) Disclamer: This is not my code, I found this commit in the fork of zmeyc. I just also need this functionality.