search

andreas / ocaml-graphql-server

GraphQL servers in OCaml
MIT License
624 stars 60 forks source link

Minor parser improvements #139

Closed keleshev closed 5 years ago

keleshev commented 5 years ago

Really cool to see the parser switch to Menhir. I thought I might chip in with a few minor parser improvements. Cherry-pick the ones you find useful.

andreas commented 5 years ago

Thanks, these look like great improvements! I prefer keeping it explicit that arguments are optional (eace7b1) though, even if it's not as terse. I'll cherry-pick and merge once v0.9.0 is out.

Don't mind the CI failure: I haven't found a good way to bump version constraints prior to getting the new package released on OPAM.

If you have any further interest in contributing to graphql_parser, I would love to rope you into adding support for "block strings" (spec) 😉

andreas commented 5 years ago

Cherry-picked and pushed to master. Thanks!