Closed naartjie closed 4 years ago
This is a nice improvement for newcomers. I'm wondering whether simply printing the suggested line to stdout would suffice rather than introduce logs
as a dependency. Did you have something particular in mind when choosing to use logs
?
Oh, I used logs
mainly because it was already in examples/server.ml
but I don't think they were turned on anyways - I don't think anything would get printed on an error the way it was.
I've replaced both the uses of logs: mine, and what was already there.
thanks!
This PR adds logging to
./examples/server.exe
and outputs a where the server URL:Hoping this makes it more intuitive for onboarding newcomers.