search

andreas / ocaml-graphql-server

GraphQL servers in OCaml
MIT License
624 stars 60 forks source link

Add ocamlformat #177

Closed naartjie closed 4 years ago

naartjie commented 4 years ago

This PR adds ocamlformat, using the conventional format.

It only brings the minimum changes necessary to format the project:

$ dune build @fmt --auto-promote

After that it is expected that @andreas would commit those changes as the main author. After that we would enforce the formatting rules on travisCI (as per @anmonteiro's suggestion) to ensure that any new code merged follows the formatting rules.

andreas commented 4 years ago

@naartjie, thanks a lot! This has been super helpful. I probably wouldn't have gotten around to doing it at this point otherwise, so really appreciate it 🙏

naartjie commented 4 years ago

Awesome @andreas. I'm super happy that I could help.

Should I take a look at setting up the Travis CI hook next - i.e. fail if the code is not formatted?

andreas commented 4 years ago

@naartjie that would be amazing 😄