andreas / ocaml-graphql-server

GraphQL servers in OCaml
MIT License
624 stars 60 forks source link

Handle missing variables as null #184

Closed andreas closed 4 years ago

andreas commented 4 years ago

As raised in #181, missing variables are currently handled incorrectly: the request should not be rejected with an error all together, rather the variable should be handled as null. This PR updates the variable handling logic, such that this is the case.

Note that the error message is not great when a missing variable is used for a required argument. This will be revisited later.

closes #181

ozanmakes commented 4 years ago

Thanks for this!