add MSVC 2019 x64 build

andreasbuhr / cppcoro

A library of C++ coroutine abstractions for the coroutines TS

MIT License

364 stars 53 forks source link

add MSVC 2019 x64 build #16

Closed Garcia6l20 closed 4 years ago

andreasbuhr commented 4 years ago

That's cool.

When I tried it, it failed because of the noop_coroutine, see https://github.com/andreasbuhr/cppcoro/runs/1294521699 . Probably you already have a fix for that, could you open a pull request with a fix towards the branch "unify_experimental_includes" please? Lewis baker suggested in https://github.com/lewissbaker/cppcoro/pull/171 to "Maybe put this inside #if CPPCORO_COMPILER_SUPPORTS_SYMMETRIC_TRANSFER and add an include of <cppcoro/config.hpp>?".

Garcia6l20 commented 4 years ago

Sure, there is also some workaround for MSVC 2017 that are not required anymore with 2019, shall I add those changes too ?

andreasbuhr commented 4 years ago

In his comments to other pull requests, Lewis Baker seemed to care about MSVC 2017, so I'd say yes, go ahead please. :-)

andreasbuhr commented 4 years ago

That's great, thanks a lot.