search

andreasbuhr / cppcoro

A library of C++ coroutine abstractions for the coroutines TS
MIT License
364 stars 53 forks source link

add C++17 test configurations #22

Closed andreasbuhr closed 3 years ago

andreasbuhr commented 3 years ago

This should work fine as soon as https://github.com/andreasbuhr/cppcoro/pull/23 and https://github.com/andreasbuhr/cppcoro/pull/24 are merged.

tobias-loew commented 3 years ago

I can confirm @andreasbuhr's obeservation: merging this PR with #23 and #24 repairs the failing tests!

andreasbuhr commented 3 years ago

It seems we were mistaken: I merged https://github.com/andreasbuhr/cppcoro/pull/23 and https://github.com/andreasbuhr/cppcoro/pull/24 and rebased this PR on top of them. With MSVC 2019 and C++17, it fails. @tobias-loew if you could have a look into this, that would be great.

andreasbuhr commented 3 years ago

@tobias-loew what would you think about this?

tobias-loew commented 3 years ago

The issue send fixed: FindCoroutines.cnake is evaluated as expected for all configurations!