search

andreasdijkman / oracle-systemd-scripts

Scripts for start/stopping Oracle databases with systemd
GNU General Public License v3.0
9 stars 2 forks source link

Can I merge this project into ansible-oracle? #3

Open Rendanic opened 3 years ago

Rendanic commented 3 years ago

Hi, As already mentioned in #1 the current implementation of systemd startup in ansible-oracle needs a rework. Why not adding this fantastic work from this project into ansible-oracle?

There is an issue with the license an I have no dea we can solve it.

I am not the owner of ansible-oracle - just a developer who did lot of changes in ansible-orracle and currently working on some more changes in it.

Do you have any idea how we can merge parts of this fantastic work into ansible-oracle without breaking the GPLv3?

Regards Thorsten

andreasdijkman commented 3 years ago

I'm totally fine with the inclusion of these repositories into ansible-oracle. The reason I chose this license is that I think changes to these scripts should flow back to this repository. If some other license then GPLv3 is compatible or allows inclusion in an MIT-licensed project, and assures that changes are flowing back into these scripts, I'm more than willing to change the license.

I think it benefits everyone, who is using this script, if bugs/changes are fixed and are shared across the community.

So any suggestions regarding license is more then welcome!

Rendanic commented 3 years ago

Thanks for the fast reply. I'll add this repo as a subtree in the root of ansible-oracle and use symbolic links inside the role. This keeps the origin of the code and gives the ability to use templates for the systemd configuration, because I create the cgroup configuration from the ulimit definition of the oracle owner in ansible inventory.

This could be a good way to keep a connection to the origin repo and usage as a role in ansible-oracle.

As long as noone changes your code in ansible-oracle the license of GPLv3 with MIT in ansible-oracle coud be fine.

A submodule could be better but I hate them, because working at customers without internet connection is pain in the ass with sumnodules...

Regards Thorsten

andreasdijkman commented 3 years ago

Please make sure you include a specific release or tag as a sub module in your project. I've created v1.0.0 as a first release, so future work (or typo's) won't impact your role. I hope I can test all my releases but if there are issues, please let me know.

Rendanic commented 3 years ago

Thanks for the answer. I am working on an implmentation in ansible-oracle.

I plan to test the installation against OL7 and OL8.

Regards Thorsten