search

andreaselia / laravel-analytics

Analytics for the Laravel framework.
MIT License
165 stars 25 forks source link

Add support for ignoring columns in the database #62

Closed grantholle closed 3 months ago

grantholle commented 4 months ago

This adds support to ignore some columns when saving the page view record, i.e. ignoring the host column since I have a single tenant app and don't need it to bloat the table.

I also changed the test function names to get rid of the deprecation warning about metadata.

andreaselia commented 4 months ago

Hey @grantholle, thanks for your PR. I'll try and take a proper look and test things out over the weekend.

Would you mind reverting the test names to keep the /** @test */ way of doing things rather than test_ please? Alternatively we could roll with the #[Test] attribute since I believe from the Laravel 11 requirements we can do that.

grantholle commented 4 months ago

I would going to use the #[Test] attribute, but then the package would have to drop support for php 7.4, as it's an 8.0 feature.

andreaselia commented 4 months ago

We can drop support for PHP 7.4, that works for me and I imagine the majority of users of the package.

grantholle commented 4 months ago

Yeah I agree. Since v2.0.0 is already tagged and is php ^8.0, might as well just go with that major version. I think you can still support the older versions of Laravel, but just bump the php requirement.

grantholle commented 4 months ago

Ok @andreaselia, should be all set now

andreaselia commented 3 months ago

Thanks @grantholle, apologies about the delay.