search

andreaselia / laravel-analytics

Analytics for the Laravel framework.
MIT License
165 stars 25 forks source link

Improve documentation #8

Closed vmitchell85 closed 3 years ago

vmitchell85 commented 3 years ago

This PR adds instructions on publishing the config file and assets.

andreaselia commented 3 years ago

Hey @vmitchell85, thanks for the PR.

I believe the install command publishes these assets already. Would you prefer we removed the install command in turn for the artisan vendor:publish publishing?

vmitchell85 commented 3 years ago

Hmm... thought I ran that... let me wipe and reinstall...

vmitchell85 commented 3 years ago

Worked that time.. nevermind... sorry.

andreaselia commented 3 years ago

No worries at all @vmitchell85, I think I may be in favour of ditching the command in favour for publishing them as in this PR as it's also less maintenance and code within the package. I'll sort it out sometime tonight unless you'd like to submit a PR to remove it and update the documentation.

vmitchell85 commented 3 years ago

I'm a little busy working on a project for a client, but if I have time I might submit a PR.