Fix collection merging bug

andreaselia / laravel-api-to-postman

Generate a Postman collection automatically from your Laravel API

MIT License

958 stars 99 forks source link

Closed Menkveld-24 closed 5 months ago

Menkveld-24 commented 7 months ago

The ->put('url') overwrites the url part of the collection instead of adding to it upon GET requests.

Snippet run in tinkerwell now correctly merges the data into the collection

Would you also like me to extend the test for this? As the test only looks for the 'query' part inside the 'url'?

andreaselia commented 7 months ago

@Menkveld-24 good spot, and thanks for the PR. If you wouldn't mind extending the test surrounding this, that would be greatly appreciated 👍

Menkveld-24 commented 6 months ago

Hi, sorry for the late response. Been busy these weeks and kinda forgot about it. I'll try to do so this week

Menkveld-24 commented 6 months ago

Hehe, I've finally made some changes. The test now checks the full get request instead of just the url query.

Also; saw this message about the deprecation of some tests or sth.

tomirons commented 6 months ago

@Menkveld-24 there's a failing test, are you able to fix it?

Menkveld-24 commented 6 months ago

Ofc! Somehow they didnt produce this error locally

Menkveld-24 commented 5 months ago

@tomirons Should be good rn

andreaselia commented 5 months ago

Thank you @Menkveld-24 and @tomirons ❤️