search

andreasgal / B2G

Boot to Gecko aims to create a complete, standalone operating system for the open web.
https://wiki.mozilla.org/B2G
908 stars 158 forks source link

Fix makefile #275

Closed mikeaich closed 12 years ago

mikeaich commented 12 years ago

The install-valgrind target has a bug in the symlink command; this change fixes it.

michaelwu commented 12 years ago

Can you make a pull request with just that change?

mikeaich commented 12 years ago

That pull request should just be that one change. The other changes are from me rolling back to an earlier rev of the file so that you wouldn't pick up everything I had tweaked.

----- Original Message -----

From: "Michael Wu" reply@reply.github.com To: "Mike Habicher" mikeh@mozilla.com Sent: Monday, 23 April, 2012 4:08:57 PM Subject: Re: [B2G] Fix makefile (#275)

Can you make a pull request with just that change?

Reply to this email directly or view it on GitHub: https://github.com/andreasgal/B2G/pull/275#issuecomment-5290456

michaelwu commented 12 years ago

I mean just one commit. Squash the commits together with interactive rebase and submit another pull request.

mikeaich commented 12 years ago

How do I do that?

----- Original Message -----

From: "Michael Wu" reply@reply.github.com To: "Mike Habicher" mikeh@mozilla.com Sent: Monday, 23 April, 2012 4:40:14 PM Subject: Re: [B2G] Fix makefile (#275)

I mean just one commit. Squash the commits together with interactive rebase and submit another pull request.

Reply to this email directly or view it on GitHub: https://github.com/andreasgal/B2G/pull/275#issuecomment-5291221

michaelwu commented 12 years ago

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

mikeaich commented 12 years ago

I did the interactive rebase, squashing my changes together, and the result is a Makefile that has a bunch of extra stuff in it that isn't ready yet and doesn't work, in addition to the bug fix I wanted to push upstream.

----- Original Message -----

From: "Michael Wu" reply@reply.github.com To: "Mike Habicher" mikeh@mozilla.com Sent: Monday, 23 April, 2012 4:43:52 PM Subject: Re: [B2G] Fix makefile (#275)

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Reply to this email directly or view it on GitHub: https://github.com/andreasgal/B2G/pull/275#issuecomment-5291306