search

andreasgerstmayr / fava-portfolio-returns

fava-portfolio-returns shows portfolio returns in Fava
GNU General Public License v2.0
38 stars 2 forks source link

Add currency mapping for unsupported currencies (Like stablecoins) #9

Closed shekohex closed 7 months ago

shekohex commented 7 months ago

It was throwing an error when using things like USDT or USDC as a currency.

shekohex commented 7 months ago

@andreasgerstmayr could you please review my PR? Thanks.

andreasgerstmayr commented 7 months ago

hi @shekohex! I don't want to maintain a list of stablecoins and their mappings to currencies in the source code, as there are potentially 100s of stablecoins.

I've updated the code to show a number format instead of currency format if the currency is not supported (#11), and additionally you can also set the target currency of the group, for example: https://github.com/andreasgerstmayr/fava-portfolio-returns/blob/405b96cff98cb94549ce575e467936d75be1b5a7/example/beangrow.pbtxt#L82-L86

shekohex commented 7 months ago

Thank you, that is better for sure!