Toggle learning translations in reading frame

andreask7 / lwt

Learning with Texts (LWT) is a tool for Language Learning. The official version (not this one) is available at :

http://lwt.sf.net

Other

33 stars 7 forks source link

Toggle learning translations in reading frame #27

Open pirtleshell opened 7 years ago

pirtleshell commented 7 years ago

Hello,

It's nice to see a more-alive fork of this project. (Especially with so many imrovements!) I added the option to toggle the showing of translations under words with learning level 1. The checkbox allows you to hide them. It does this by adding a setting to the settings table under the key showlearningtranslations.

When on:

When off:

Uses set_text_mode.php:

I removed trailing spaces in the files I changed. They are in separate commits so you can more easily see what's going on by looking at the individual differences between commits.

shaund commented 6 years ago

@pirtleshell There's no issues on your fork, else I would have put this there, though I guess it's relevant here too. I pulled your mine branch and am running it, but the Learning Translations checkbox isn't doing anything. If I uncheck it, nothing happens, and when I refresh the page, it's checked again.

I checked the database and saw showlearningtranslations wasn't added to the settings. I've manually added it, and now translations are hidden if I set it to 0 and shown if set to 1, but the checkbox isn't changing the values.

Also #26 is still present in your fork. It doesn't happen in https://github.com/lwt-project/lwt

shaund commented 6 years ago

Not sure what happened, but it's working now.

pirtleshell commented 6 years ago

Haha, hi @shaund. Did you manage to get it all working? I haven't used this in over a year so it's very likely that the code could have diverged greatly enough to have broken some things.

I'm also not sure what the state of this repo is. I made this PR because at the time this seemed to be a more active fork than the original. I also appreciated the speedups and decreased database size as well as all the other general enhancements. However, there doesn't seem to be any unified work being done on the Learning With Texts software... 😞

Now that the original is being more actively updated, it might be worthwhile to migrate some of the improvements made here to the original and see if we can get a more concerted dev effort on the project.

argovela commented 6 years ago

Hello,

On Tue, May 22, 2018, 11:43 Robert Pirtle notifications@github.com wrote:

Now that the original is being more actively updated, it might be worthwhile to migrate some of the improvements made here to the original and see if we can get a more concerted dev effort on the project.

Is there any forum where any such development work is being discussed? On any lwt-like software?

Forgive the hijack.

Hannes.