Email address marked complete when a full domain name is missing

andreaskasper / scoringCE

https://scoring.dance

0 stars 0 forks source link

Email address marked complete when a full domain name is missing #2

Open shabanski opened 2 years ago

shabanski commented 2 years ago

Email address field marks the value as a "complete email address" even if the domain name is not complete: Screenshot_20220104-233201~2

mbwinkler commented 2 years ago

To add on to the Issue description.

Email validation accepts some, but not all unicode and special characters. RFC 5322 compliant Regex to solve this issue.
Name and Surname also accepts all unicode characters AND ALL types of brackets, points and semicolons. Potential code injection risk. Don't have a good validation Regex on hand for that one, but should be a quick fix.
Birthday accepts future dates.

andreaskasper commented 2 years ago

Hi, thanks for the info. I'll add validations to that fields. Currently it just checks != "" - I'm happy when I get the name of the competitors. Birthday is only used to determine Sophisticated and Masters Division.

Thanks a lot for your testing and reporting 🤗🤗🤗🤗🤗 andi