search

andreaskou / PHPBB_IUM

PhpBB Inactive User Management/Reminder
GNU General Public License v2.0
4 stars 7 forks source link

make logs searchable, return linebreak in reminder mails #22

Closed wcz-txp closed 3 years ago

wcz-txp commented 3 years ago

Hi Andreas, I recognized, that the logs in ACP weren't searchable, so I couldn't check, whether reminder mails were sent and how many. So the solution I found was, that SENT_REMINDERS and the other used log variables should be renamed to LOG_SENT_REMINDERS and after that searching for the term "reminder" or in German "Erinnerung" was successful. Before that, I could only find the log entries by typing "250".

Also I recognized, that in your last stable version the "PHP_EOL" in function make_topics in reminder.php disappeared, therefore the mails with topics got sometimes bad readable..

andreaskou commented 3 years ago

Hi, sorry for not responding earlier. Thanks first of all. I was aware for the EOL issue and I already have posted in php a small change that can fix this. But I need confirmation from the php team if this can be used or there is another/better way.

As for the LOG_* I will make the changes as soon as I have the answer from the phpbb team. I'll have to close this without merging since removing EOL was phpbb teams request.

wcz-txp commented 3 years ago

Ah, ok, I see. This log searching was something I really needed, to monitor the behaviour of this extension. I think, that would be useful for others too.

This would be the list for my live forum, after searching for "reminder" in German. изображение