search

andreasohlund / APIComparer

Compares NuGetPackages/Assemblies and displays changes in the public api.
MIT License
51 stars 4 forks source link

Added support for wildcard urls #41

Closed andreasohlund closed 9 years ago

andreasohlund commented 9 years ago

Fixes #8

Outstanding questions:

andreasohlund commented 9 years ago

@ParticularLabs/apicomparer your thoughts on the questions above?

danielmarbach commented 9 years ago

Why do we have to do this on the front-end?

I know when you in the future expand functionality in the frontend we eventually will need to browse packages. Until then I think we should do nuget related stuff in the bakend

Am 03.05.2015 um 21:24 schrieb Andreas Öhlund notifications@github.com:

@ParticularLabs/apicomparer your thoughts on the questions above?

— Reply to this email directly or view it on GitHub.

SeanFeldman commented 9 years ago

I don't like throwing in this case. It is not a logical error that requires an exception.

andreasohlund commented 9 years ago

Why do we have to do this on the front-end?

So we can response redirect easily? (I've missed that from the pull actually)

andreasohlund commented 9 years ago

After talking to @danielmarbach we realized that we need to do the checks on the frontend like we do in this pull to avoid sending a message to the backend for each request. This way we can detect and serve static html most of the time

andreasohlund commented 9 years ago

@ParticularLabs/apicomparer the wildcards now works (with redirects if either the left or right version is expanded).

There are still 2 things left todo:

  1. Testing, how should we play that, perhaps just a integration test(s) hitting the real nuget feeds using https://github.com/NancyFx/Nancy/wiki/Testing-your-application to run the whole module?
  2. Error handling: I've raised a separate issue for this and I propose we make that out of scope for this pull? #43

Comments?

andreasohlund commented 9 years ago

Decided to provide some naive error handling for now. Merging