search

andreasohlund / APIComparer

Compares NuGetPackages/Assemblies and displays changes in the public api.
MIT License
51 stars 4 forks source link

Detect and display diffs with no changes properly #44

Closed andreasohlund closed 9 years ago

andreasohlund commented 9 years ago

Fixes #26

@danielmarbach I'm a handlebars noob so please review this one. Especially the whitespace added? (see the changes to the .approved files)

danielmarbach commented 9 years ago

Handlebars.net doesn't allow to control the whitespace yet. Only one minor: how about combining hasChanges with the flags from previous Any() calls via let binding?

Am 25.07.2015 um 20:50 schrieb Andreas Öhlund notifications@github.com:

Fixes #26

@danielmarbach I'm a handlebars noob so please review this one. Especially the whitespace added? (see the changes to the .approved files)

You can view, comment on, or merge this pull request online at:

https://github.com/ParticularLabs/APIComparer/pull/44

Commit Summary

Detect and display diffs with no changes properly File Changes

A APIComparer.Backend.Tests/APIUpgradeToHtmlFormatterTest.AppccelerateEventBrokerNoChanges.approved.html (10) M APIComparer.Backend.Tests/APIUpgradeToHtmlFormatterTest.TestComplianceAzureSelfDestruct.approved.html (11) M APIComparer.Backend.Tests/APIUpgradeToHtmlFormatterTest.TestComplianceNServiceBus.approved.html (12) M APIComparer.Backend.Tests/APIUpgradeToHtmlFormatterTest.TestComplianceNewtonsoftJson.approved.html (74) M APIComparer.Backend.Tests/APIUpgradeToHtmlFormatterTest.cs (22) M APIComparer.Backend/Reporting/Templates.Html.cs (14) M APIComparer.Backend/Reporting/ViewModelBuilder.cs (3) Patch Links:

https://github.com/ParticularLabs/APIComparer/pull/44.patch https://github.com/ParticularLabs/APIComparer/pull/44.diff — Reply to this email directly or view it on GitHub.