search

andreasohlund / APIComparer

Compares NuGetPackages/Assemblies and displays changes in the public api.
MIT License
51 stars 4 forks source link

NuGet Packages Breaking Change Report #56

Closed DavidBoike closed 8 years ago

DavidBoike commented 8 years ago

I'm querying NuGet packages and then generating a report to show breaking changes from the corresponding minor and major versions. So for example if the current version of something is 6.2.3, it would discover breaking changes from 6.20...6.2.3 and 6.0.0...6.2.3.

One test does this for the top 25 popular NuGet packages (that have .NET sources) and the other does it for our NServiceBus packages.

I needed to change the ViewModel for the API compare to static types so I could use them more easily from other code, and expand them to count breaking changes, but functionality should be unchanged. I also had to take a dependency on NuGet.Core in the Backend Tests.

@ParticularLabs/apicomparer please review.

DavidBoike commented 8 years ago

Sample reports:

SimonCropp commented 8 years ago

all this looks ok to me. however it seems a few of the tests are not really tests but helpers for you to generate some ad-hoc reports. is this correct? if so there is nothing wrong with this but can you make them explicit and comment them as such so in the future they can be cleaned up

DavidBoike commented 8 years ago

Mods based on Simons comments. Most importantly made these two tests explicit since they aren't really tests in the truest fashion.

SeanFeldman commented 8 years ago

@DavidBoike is this PR dead or you'll work on it?

DavidBoike commented 8 years ago

Forgot about this. As far as I'm concerned it's mergeable, unless it conflicts with the other data model changes @andreasohlund had in progress.

andreasohlund commented 8 years ago

They are similar but not conflicting