AutoMapper 4.2.1...5.0.0 blows

[andreasohlund]

http://apicomparer-preview.particular.net/compare/AutoMapper/4.2.1...5.0.0

AutoMapper comparison between 4.2.1 and 5.0.0 has failed with the following error: 'AutoMapper' already has a dependency defined for 'Microsoft.CSharp'.

cc @jbogard

[devlead]

Interestingly I got a similar error with newly released Newtonsoft.Json 9.0.1 but 8.0.3 works.

[andreasohlund]

net core?

[jbogard]

Net Standard library perhaps too.

On Tue, Jun 28, 2016 at 9:01 AM, Andreas Öhlund notifications@github.com wrote:

net core?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ParticularLabs/APIComparer/issues/70#issuecomment-229057972, or mute the thread https://github.com/notifications/unsubscribe/AAGYMqnRONu_f7LLfhf9jJpBWb3xsF4jks5qQSk4gaJpZM4JAG-W .

[devlead]

9.0.1

8.0.3

There's 1 new folder, seems to give issues on mono too.

[devlead]

NuSpec a bit beefer now gone from

<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>Newtonsoft.Json</id>
    <version>8.0.3</version>
    <title>Json.NET</title>
    <authors>James Newton-King</authors>
    <owners>James Newton-King</owners>
    <licenseUrl>https://raw.github.com/JamesNK/Newtonsoft.Json/master/LICENSE.md</licenseUrl>
    <projectUrl>http://www.newtonsoft.com/json</projectUrl>
    <iconUrl>http://www.newtonsoft.com/content/images/nugeticon.png</iconUrl>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>Json.NET is a popular high-performance JSON framework for .NET</description>
    <language>en-US</language>
    <tags>json</tags>
  </metadata>
</package>

to

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata>
    <id>Newtonsoft.Json</id>
    <version>9.0.1</version>
    <title>Json.NET</title>
    <authors>James Newton-King</authors>
    <owners>James Newton-King</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <licenseUrl>https://raw.github.com/JamesNK/Newtonsoft.Json/master/LICENSE.md</licenseUrl>
    <projectUrl>http://www.newtonsoft.com/json</projectUrl>
    <iconUrl>http://www.newtonsoft.com/content/images/nugeticon.png</iconUrl>
    <description>Json.NET is a popular high-performance JSON framework for .NET</description>
    <language>en-US</language>
    <tags>json</tags>
    <dependencies>
      <group targetFramework=".NETFramework4.5" />
      <group targetFramework=".NETFramework4.0" />
      <group targetFramework=".NETFramework3.5" />
      <group targetFramework=".NETFramework2.0" />
      <group targetFramework=".NETPortable4.5-Profile259" />
      <group targetFramework=".NETPortable4.0-Profile328" />
      <group targetFramework=".NETStandard1.0">
        <dependency id="Microsoft.CSharp" version="4.0.1" />
        <dependency id="System.Collections" version="4.0.11" />
        <dependency id="System.Diagnostics.Debug" version="4.0.11" />
        <dependency id="System.Dynamic.Runtime" version="4.0.11" />
        <dependency id="System.Globalization" version="4.0.11" />
        <dependency id="System.IO" version="4.1.0" />
        <dependency id="System.Linq" version="4.1.0" />
        <dependency id="System.Linq.Expressions" version="4.1.0" />
        <dependency id="System.ObjectModel" version="4.0.12" />
        <dependency id="System.Reflection" version="4.1.0" />
        <dependency id="System.Reflection.Extensions" version="4.0.1" />
        <dependency id="System.Resources.ResourceManager" version="4.0.1" />
        <dependency id="System.Runtime" version="4.1.0" />
        <dependency id="System.Runtime.Extensions" version="4.1.0" />
        <dependency id="System.Runtime.Serialization.Primitives" version="4.1.1" />
        <dependency id="System.Text.Encoding" version="4.0.11" />
        <dependency id="System.Text.Encoding.Extensions" version="4.0.11" />
        <dependency id="System.Text.RegularExpressions" version="4.1.0" />
        <dependency id="System.Threading" version="4.0.11" />
        <dependency id="System.Threading.Tasks" version="4.0.11" />
        <dependency id="System.Xml.ReaderWriter" version="4.0.11" />
        <dependency id="System.Xml.XDocument" version="4.0.11" />
      </group>
    </dependencies>
  </metadata>
</package>

[andreasohlund]

'AutoMapper' already has a dependency defined for 'Microsoft.CSharp'. => pretty sure that error comes from Mono.Cecil

[devlead]

Hmm checking reference it has difference target framework syntax i.e. (<group targetFramework="net20">, <group targetFramework="net40">, <group targetFramework="net45">, etc. similar to the folder structure) https://docs.nuget.org/create/nuspec-reference

[devlead]

Automapper less difference basically <group targetFramework=".NETPlatform5.1"> went to <group targetFramework=".NETStandard1.1"> and <group targetFramework=".NETStandard1.3">

[andreasohlund]

Actually, wonder if this is a nuget issue, I'll try to update to latest nuget.core

[devlead]

Could be that you need nuget3 now, which nuget core doesn't support.

[andreasohlund]

updating to latest nuget seemed to fix it locally

[andreasohlund]

Shit, issue is still there http://apicomparer-preview.particular.net/compare/AutoMapper/4.2.0...5.0.0

json.net does work now though

http://apicomparer-preview.particular.net/compare/newtonsoft.json/8.0.3...9.0.1

[andreasohlund]

@jbogard this is now fixed

http://apicomparer.particular.net/compare/AutoMapper/4.2.1...5.0.0

it was the nuget update that fixed it but our deploy was broken at that time. This is fixes so we're all good