search

andreasonny83 / angular2-cookie-law

Angular2+ component that provides a banner to inform users about cookie law
https://stackblitz.com/edit/angular2-cookie-law
MIT License
37 stars 24 forks source link

Support for Angular 8 #42

Open stevenlauwers22 opened 5 years ago

stevenlauwers22 commented 5 years ago

I've upgraded my application to Angular 8 and I'm getting some warnings on this package. Could you update your package.json file to also allow angular 8, so I can get rid of these warnings.

warning " > angular2-cookie-law@7.0.1" has incorrect peer dependency "@angular/common@^6.0.0-rc.0 || ^6.0.0 || 7.0.0-rc.0 || ^7.0.0".
warning " > angular2-cookie-law@7.0.1" has incorrect peer dependency "@angular/core@^6.0.0-rc.0 || ^6.0.0 || 7.0.0-rc.0 || ^7.0.0".
evolkmann commented 4 years ago

Hi @stevenlauwers22, since this lib seems to be discontinued unfortunately, I took the time to rewrite this library to angular 9. I also removed much of the opinionated behaviour.

Maybe this is interesting for your: https://github.com/exportarts/ngx-cookie-banner

stevenlauwers22 commented 4 years ago

Hi @evolkmann, thanks for pointing out!

HelainSchoonjans commented 4 years ago

Ngx-cookie-banner unfortunately does not support Angular 8... Won't anyone fork and upgrade angular2-cookie-law?

evolkmann commented 4 years ago

@HelainSchoonjans You are right, it says so in the peer dependencies. I will change that in a moment and go back to v8. I did expect v9 to arrive earlier, and I am using the prerelease CLI on my machine already. Nevertheless, the software is still working with angular 8 I am pretty sure.

evolkmann commented 4 years ago

@HelainSchoonjans I did not fork it, because I wanted to get rid of the opinionated styling. It was easier to take only the useful parts of the logic and refactor them in the process.

evolkmann commented 4 years ago

@HelainSchoonjans You are right, it says so in the peer dependencies. I will change that in a moment and go back to v8. I did expect v9 to arrive earlier, and I am using the prerelease CLI on my machine already. Nevertheless, the software is still working with angular 8 I am pretty sure.

v0.0.3 has now been released: https://www.npmjs.com/package/ngx-cookie-banner

andreasonny83 commented 4 years ago

I'm sorry but I'm not actively maintaining the package any more. I will be happy to accept a PR to add compatibility from major Angular versions if you can help.

Thanks